mirror of
https://github.com/astral-sh/setup-uv.git
synced 2026-11-05 01:35:32 +00:00
With `cache-python: true`, a Windows runner can report a cache hit while extracting the cache incorrectly. When `@actions/cache`'s tar extracts uv's minor-version junction before the patch directory it points to, it creates a file symlink. Resolving that link later raises `[WinError 5] Access is denied`. This PR fixes things up after restoring the Python cache, recreating the junction if resolving the link fails with access denied and its recorded target is a matching, accessible CPython installation in the same directory. This is a temporary workaround until https://github.com/actions/toolkit/issues/2562 gets resolved and `@actions/cache` itself becomes resilient to these situations. I tested this by restoring the same archive on two fresh `windows-2022` runners. The original run passed because resolving the minor-version link raised the expected WinError 5. With the patch, `uv sync --offline --managed-python --no-python-downloads` created a virtual environment whose `home` in `pyvenv.cfg` resolved to the cached CPython 3.10.22 installation. [Original run](https://github.com/astral-sh/ruff/actions/runs/41469344610/job/125358623949#step:9:1) · [Patched run](https://github.com/astral-sh/ruff/actions/runs/41469344610/job/125358623835#step:10:1).
153 lines
4.6 KiB
TypeScript
153 lines
4.6 KiB
TypeScript
import { fileURLToPath } from "node:url";
|
|
import { beforeEach, describe, expect, it, jest } from "@jest/globals";
|
|
import { createSetupInputs } from "../helpers/setup-inputs";
|
|
|
|
const mockRestoreCache = jest.fn();
|
|
const mockSaveState = jest.fn();
|
|
const mockSetOutput = jest.fn();
|
|
const mockGetArch = jest.fn(() => "x86_64");
|
|
const mockGetOSNameVersion = jest.fn(() => "ubuntu-24.04");
|
|
const mockGetPlatform = jest.fn(async () => "unknown-linux-gnu");
|
|
|
|
jest.unstable_mockModule("@actions/cache", () => ({
|
|
restoreCache: mockRestoreCache,
|
|
}));
|
|
|
|
jest.unstable_mockModule("@actions/core", () => ({
|
|
saveState: mockSaveState,
|
|
setOutput: mockSetOutput,
|
|
}));
|
|
|
|
jest.unstable_mockModule("../../src/hash/hash-files", () => ({
|
|
hashFiles: jest.fn(async () => "dependencyhash"),
|
|
}));
|
|
|
|
jest.unstable_mockModule("../../src/utils/logging", () => ({
|
|
info: jest.fn(),
|
|
warning: jest.fn(),
|
|
}));
|
|
|
|
jest.unstable_mockModule("../../src/utils/platforms", () => ({
|
|
getArch: mockGetArch,
|
|
getOSNameVersion: mockGetOSNameVersion,
|
|
getPlatform: mockGetPlatform,
|
|
}));
|
|
|
|
const { restoreCache } = await import("../../src/cache/restore-cache");
|
|
|
|
function cacheKeyOutput(): string {
|
|
const call = mockSetOutput.mock.calls.find(([name]) => name === "cache-key");
|
|
expect(call).toBeDefined();
|
|
return call?.[1] as string;
|
|
}
|
|
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
mockGetArch.mockReturnValue("x86_64");
|
|
mockGetOSNameVersion.mockReturnValue("ubuntu-24.04");
|
|
mockGetPlatform.mockResolvedValue("unknown-linux-gnu");
|
|
});
|
|
|
|
describe("restoreCache", () => {
|
|
it.each([
|
|
["win32", false],
|
|
["linux", true],
|
|
] as const)(
|
|
"keeps the matched Python cache key on %s when the install directory cannot be read",
|
|
async (platform, pythonCacheHit) => {
|
|
const inputs = createSetupInputs({
|
|
cachePython: true,
|
|
// A file at the install directory path makes readdir fail.
|
|
pythonDir: fileURLToPath(import.meta.url),
|
|
restoreCache: true,
|
|
});
|
|
mockRestoreCache
|
|
.mockReturnValueOnce("uv-key")
|
|
.mockReturnValueOnce("python-key");
|
|
|
|
const originalPlatform = process.platform;
|
|
Object.defineProperty(process, "platform", { value: platform });
|
|
try {
|
|
await restoreCache(inputs);
|
|
} finally {
|
|
Object.defineProperty(process, "platform", { value: originalPlatform });
|
|
}
|
|
|
|
expect(mockSetOutput).toHaveBeenCalledWith("cache-hit", true);
|
|
expect(mockSetOutput).toHaveBeenCalledWith(
|
|
"python-cache-hit",
|
|
pythonCacheHit,
|
|
);
|
|
expect(mockSaveState).toHaveBeenCalledWith(
|
|
"python-cache-matched-key",
|
|
"python-key",
|
|
);
|
|
},
|
|
);
|
|
|
|
it("encodes Python version ranges before adding them to the cache key", async () => {
|
|
await restoreCache(createSetupInputs(), ">3.10.11,<3.11");
|
|
|
|
const cacheKey = cacheKeyOutput();
|
|
|
|
expect(cacheKey).not.toContain(",");
|
|
expect(cacheKey).toContain("-%3E3.10.11%2C%3C3.11-");
|
|
});
|
|
|
|
it("encodes cache suffixes before adding them to the cache key", async () => {
|
|
const inputs = createSetupInputs({ cacheSuffix: "tests-3.10,3.11" });
|
|
|
|
await restoreCache(inputs, "3.11");
|
|
|
|
const cacheKey = cacheKeyOutput();
|
|
|
|
expect(cacheKey).not.toContain(",");
|
|
expect(cacheKey).toContain("-tests-3.10%2C3.11");
|
|
});
|
|
|
|
it("uses an unpruned cache key by default", async () => {
|
|
const inputs = createSetupInputs({ cacheSuffix: "tests-3.11" });
|
|
|
|
await restoreCache(inputs, "3.11");
|
|
|
|
expect(cacheKeyOutput()).toBe(
|
|
"setup-uv-2-x86_64-unknown-linux-gnu-ubuntu-24.04-3.11-dependencyhash-tests-3.11",
|
|
);
|
|
});
|
|
|
|
it("includes the resolved Python architecture in the cache key", async () => {
|
|
const inputs = createSetupInputs({ pythonArch: "aarch64" });
|
|
|
|
await restoreCache(inputs, "3.14");
|
|
|
|
expect(cacheKeyOutput()).toContain("-3.14-python-aarch64-");
|
|
});
|
|
|
|
it.each(["aarch64", "x86_64"])(
|
|
"separates %s Python caches on a Windows ARM64 runner",
|
|
async (pythonArch) => {
|
|
mockGetArch.mockReturnValue("aarch64");
|
|
mockGetOSNameVersion.mockReturnValue("windows-11");
|
|
mockGetPlatform.mockResolvedValue("pc-windows-msvc");
|
|
const inputs = createSetupInputs({
|
|
cachePython: true,
|
|
pythonArch,
|
|
restoreCache: true,
|
|
});
|
|
|
|
await restoreCache(inputs, "3.14");
|
|
|
|
const cacheKey = `setup-uv-2-aarch64-pc-windows-msvc-windows-11-3.14-python-${pythonArch}-py-dependencyhash`;
|
|
expect(cacheKeyOutput()).toBe(cacheKey);
|
|
expect(mockRestoreCache).toHaveBeenCalledWith(
|
|
[inputs.cacheLocalPath?.path],
|
|
cacheKey,
|
|
);
|
|
expect(mockRestoreCache).toHaveBeenCalledWith(
|
|
[inputs.pythonDir],
|
|
`${cacheKey}-python`,
|
|
);
|
|
},
|
|
);
|
|
});
|