mirror of
https://github.com/astral-sh/setup-uv.git
synced 2026-11-12 01:49:33 +00:00
With `cache-python: true`, a Windows runner can report a cache hit while extracting the cache incorrectly. When `@actions/cache`'s tar extracts uv's minor-version junction before the patch directory it points to, it creates a file symlink. Resolving that link later raises `[WinError 5] Access is denied`. This PR fixes things up after restoring the Python cache, recreating the junction if resolving the link fails with access denied and its recorded target is a matching, accessible CPython installation in the same directory. This is a temporary workaround until https://github.com/actions/toolkit/issues/2562 gets resolved and `@actions/cache` itself becomes resilient to these situations. I tested this by restoring the same archive on two fresh `windows-2022` runners. The original run passed because resolving the minor-version link raised the expected WinError 5. With the patch, `uv sync --offline --managed-python --no-python-downloads` created a virtual environment whose `home` in `pyvenv.cfg` resolved to the cached CPython 3.10.22 installation. [Original run](https://github.com/astral-sh/ruff/actions/runs/41469344610/job/125358623949#step:9:1) · [Patched run](https://github.com/astral-sh/ruff/actions/runs/41469344610/job/125358623835#step:10:1).
126 lines
4.2 KiB
TypeScript
126 lines
4.2 KiB
TypeScript
import * as cache from "@actions/cache";
|
|
import * as core from "@actions/core";
|
|
import { hashFiles } from "../hash/hash-files";
|
|
import type { SetupInputs } from "../utils/inputs";
|
|
import * as log from "../utils/logging";
|
|
import { getArch, getOSNameVersion, getPlatform } from "../utils/platforms";
|
|
import { repairPythonJunctions } from "./repair-python-junctions";
|
|
|
|
export const STATE_CACHE_KEY = "cache-key";
|
|
export const STATE_CACHE_MATCHED_KEY = "cache-matched-key";
|
|
export const STATE_PYTHON_CACHE_MATCHED_KEY = "python-cache-matched-key";
|
|
|
|
const CACHE_VERSION = "2";
|
|
|
|
export async function restoreCache(
|
|
inputs: SetupInputs,
|
|
pythonVersion?: string,
|
|
): Promise<void> {
|
|
const cacheKey = await computeKeys(inputs, pythonVersion);
|
|
core.saveState(STATE_CACHE_KEY, cacheKey);
|
|
core.setOutput("cache-key", cacheKey);
|
|
|
|
if (!inputs.restoreCache) {
|
|
log.info("restore-cache is false. Skipping restore cache step.");
|
|
core.setOutput("python-cache-hit", false);
|
|
return;
|
|
}
|
|
|
|
if (inputs.cacheLocalPath === undefined) {
|
|
throw new Error(
|
|
"cache-local-path is not set. Cannot restore cache without a valid cache path.",
|
|
);
|
|
}
|
|
|
|
await restoreCacheFromKey(
|
|
cacheKey,
|
|
inputs.cacheLocalPath.path,
|
|
STATE_CACHE_MATCHED_KEY,
|
|
"cache-hit",
|
|
);
|
|
|
|
if (inputs.cachePython) {
|
|
await restoreCacheFromKey(
|
|
`${cacheKey}-python`,
|
|
inputs.pythonDir,
|
|
STATE_PYTHON_CACHE_MATCHED_KEY,
|
|
"python-cache-hit",
|
|
// TODO: Remove this repair once @actions/cache preserves Windows junctions.
|
|
// https://github.com/actions/toolkit/issues/2562
|
|
process.platform === "win32" ? repairPythonJunctions : undefined,
|
|
);
|
|
} else {
|
|
core.setOutput("python-cache-hit", false);
|
|
}
|
|
}
|
|
|
|
async function restoreCacheFromKey(
|
|
cacheKey: string,
|
|
cachePath: string,
|
|
stateKey: string,
|
|
outputKey: string,
|
|
afterRestore?: (cachePath: string) => Promise<void>,
|
|
): Promise<void> {
|
|
log.info(
|
|
`Trying to restore cache from GitHub Actions cache with key: ${cacheKey}`,
|
|
);
|
|
try {
|
|
const matchedKey = await cache.restoreCache([cachePath], cacheKey);
|
|
if (!matchedKey) {
|
|
log.info(`No GitHub Actions cache found for key: ${cacheKey}`);
|
|
core.setOutput(outputKey, false);
|
|
return;
|
|
}
|
|
|
|
// Record the match before the post-restore hook so the post step can skip
|
|
// archiving the directory again even if the hook fails. A PR that restored
|
|
// from its base branch could otherwise save the broken copy in its own cache.
|
|
core.saveState(stateKey, matchedKey);
|
|
await afterRestore?.(cachePath);
|
|
log.info(
|
|
`cache restored from GitHub Actions cache with key: ${matchedKey}`,
|
|
);
|
|
core.setOutput(outputKey, true);
|
|
} catch (err) {
|
|
const message = (err as Error).message;
|
|
log.warning(message);
|
|
core.setOutput(outputKey, false);
|
|
}
|
|
}
|
|
|
|
async function computeKeys(
|
|
inputs: SetupInputs,
|
|
pythonVersion?: string,
|
|
): Promise<string> {
|
|
let cacheDependencyPathHash = "-";
|
|
if (inputs.cacheDependencyGlob !== "") {
|
|
log.info(
|
|
`Searching files using cache dependency glob: ${inputs.cacheDependencyGlob.split("\n").join(",")}`,
|
|
);
|
|
cacheDependencyPathHash += await hashFiles(
|
|
inputs.cacheDependencyGlob,
|
|
true,
|
|
);
|
|
if (cacheDependencyPathHash === "-") {
|
|
log.warning(
|
|
`No file matched to [${inputs.cacheDependencyGlob.split("\n").join(",")}]. The cache will never get invalidated. Make sure you have checked out the target repository and configured the cache-dependency-glob input correctly.`,
|
|
);
|
|
}
|
|
}
|
|
if (cacheDependencyPathHash === "-") {
|
|
cacheDependencyPathHash = "-no-dependency-glob";
|
|
}
|
|
const suffix = inputs.cacheSuffix
|
|
? `-${encodeURIComponent(inputs.cacheSuffix)}`
|
|
: "";
|
|
const version = encodeURIComponent(pythonVersion ?? "unknown");
|
|
const pythonArchKey = inputs.pythonArch
|
|
? `-python-${encodeURIComponent(inputs.pythonArch)}`
|
|
: "";
|
|
const platform = await getPlatform();
|
|
const osNameVersion = getOSNameVersion();
|
|
const pruned = inputs.pruneCache ? "-pruned" : "";
|
|
const python = inputs.cachePython ? "-py" : "";
|
|
return `setup-uv-${CACHE_VERSION}-${getArch()}-${platform}-${osNameVersion}-${version}${pythonArchKey}${pruned}${python}${cacheDependencyPathHash}${suffix}`;
|
|
}
|