mirror of
https://github.com/astral-sh/setup-uv.git
synced 2026-11-05 01:35:32 +00:00
Zsolt DollensteinandGitHub
fce2a640fd
With `cache-python: true`, a Windows runner can report a cache hit while extracting the cache incorrectly. When `@actions/cache`'s tar extracts uv's minor-version junction before the patch directory it points to, it creates a file symlink. Resolving that link later raises `[WinError 5] Access is denied`. This PR fixes things up after restoring the Python cache, recreating the junction if resolving the link fails with access denied and its recorded target is a matching, accessible CPython installation in the same directory. This is a temporary workaround until https://github.com/actions/toolkit/issues/2562 gets resolved and `@actions/cache` itself becomes resilient to these situations. I tested this by restoring the same archive on two fresh `windows-2022` runners. The original run passed because resolving the minor-version link raised the expected WinError 5. With the patch, `uv sync --offline --managed-python --no-python-downloads` created a virtual environment whose `home` in `pyvenv.cfg` resolved to the cached CPython 3.10.22 installation. [Original run](https://github.com/astral-sh/ruff/actions/runs/41469344610/job/125358623949#step:9:1) · [Patched run](https://github.com/astral-sh/ruff/actions/runs/41469344610/job/125358623835#step:10:1).
61 lines
1.9 KiB
TypeScript
61 lines
1.9 KiB
TypeScript
import { readdir, readlink, realpath, symlink, unlink } from "node:fs/promises";
|
|
import nodePath from "node:path";
|
|
|
|
export async function repairPythonJunctions(pythonDir: string): Promise<void> {
|
|
const entries = await readdir(pythonDir, { withFileTypes: true });
|
|
const directories = new Set(
|
|
entries
|
|
.filter((entry) => entry.isDirectory())
|
|
.map((entry) => entry.name.toLowerCase()),
|
|
);
|
|
|
|
for (const entry of entries) {
|
|
const name = entry.name.toLowerCase();
|
|
if (!entry.isSymbolicLink() || !/^cpython-\d+\.\d+[+-].+$/.test(name)) {
|
|
continue;
|
|
}
|
|
const link = nodePath.join(pythonDir, entry.name);
|
|
let target: string;
|
|
try {
|
|
target = nodePath.resolve(pythonDir, await readlink(link));
|
|
} catch (err) {
|
|
// Fail only if the link still has the access error that requires repair.
|
|
if (await resolvesWithAccessDenied(link)) {
|
|
throw err;
|
|
}
|
|
continue;
|
|
}
|
|
|
|
// uv omits only the patch and prerelease from its minor-version links.
|
|
const sibling = nodePath.relative(pythonDir, target).toLowerCase();
|
|
const version = /^(cpython-\d+\.\d+)\.\d+(?:(?:a|b|rc)\d+)?([+-].+)$/.exec(
|
|
sibling,
|
|
);
|
|
if (
|
|
!version ||
|
|
version[1] + version[2] !== name ||
|
|
!directories.has(sibling)
|
|
) {
|
|
continue;
|
|
}
|
|
// Git for Windows tar can restore a junction as a file symlink when it
|
|
// extracts the link before its target. Opening it as a directory fails.
|
|
if (!(await resolvesWithAccessDenied(link))) {
|
|
continue;
|
|
}
|
|
// An inaccessible installation can also cause EPERM through a valid link.
|
|
await realpath(target);
|
|
await unlink(link);
|
|
await symlink(target, link, "junction");
|
|
}
|
|
}
|
|
|
|
async function resolvesWithAccessDenied(link: string): Promise<boolean> {
|
|
try {
|
|
await realpath(link);
|
|
return false;
|
|
} catch (err) {
|
|
return (err as NodeJS.ErrnoException).code === "EPERM";
|
|
}
|
|
}
|